fix: move ssrContext setting to core (#349, #370) #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulivz
reviewed
May 9, 2018
| @@ -80,5 +80,12 @@ export default { | |||
| this.$route.path | |||
| ) | |||
| } | |||
| }, | |||
| created () { | |||
There was a problem hiding this comment.
It shouldn't be placed here, or it will be invoked for each component.
There was a problem hiding this comment.
If we don't put it here, we have some other choices:
- Ask users to put it mannually into the custom
Layout.vue - Wrap the
themeLayoutwith another component, to which inject this snippets. fix: move ssrContext and updateMeta to core (#349, #370) #389
| return { | ||
| path: '', | ||
| frontmatter: {} | ||
| } |
There was a problem hiding this comment.
Without this, there will be errors rendering NotFound.vue, as there is no $page match it. So we have to return an empty page data.
There was a problem hiding this comment.
In fact it to fix a bug, and this bug has something to do with this PR.
I'll extract it to another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ssrContextis necessary for SSR, so it should be in the core, not in the default theme. Title and description in custom theme #349NotFound.vuedoesn't match any$page, so I provide an empty page data for it inlib/app/util.js/findPageForPath, or errors will occur when rendering it. NotFound.vue missing title and description #370dataMixinis not onlydataafter this PR, consider renaming it toglobalMixin? @ulivz